timtebeek commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1515932350
> You can assign these reviews to me. I might not get to all of them this quickly but they're not hard to review. Appreciate it! I'll start with the project that benefit the most; then work my way down to the long tail of incidental usage, as soon as we check off the following item: > I would like it if you can amend the commit messages so they no longer say "Co-authored-by: Moderne". The only way I can change this now would be to manually amend the commits, which I'd like to avoid given that I'd like to keep these changes automated as much as possible. Is there anything in particular you don't like about the co-authored? For what it's worth: from our users we hear that they like being able to distinguish between automated and manual changes. The former are broad sweeping changes with a typically narrow scope, whereas large manual changes can be more error-prone. Recording this as co-authored was then one of the few ways to capture this in GitHub. > Longer term, we might want to look into a flow analysis tool that can tell us when the null checks are unneeded, but baby steps for now. Agree with the approach at making gradual changes here; We have some capabilities and recipes in this space, that we can explore once we get this initial batch through. I'll likely do a write up on the mailinglist at some point with what's already been done, and what we can possibly do next, if there's interest in further changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
