gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1163893091
##########
maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -1679,4 +1681,13 @@ public ProjectBuildingRequest
getProjectBuildingRequest() {
public void setProjectBuildingRequest(ProjectBuildingRequest
projectBuildingRequest) {
this.projectBuilderConfiguration = projectBuildingRequest;
}
+
+ /**
+ * @since 4.0.0
+ * @return the rootdir for this project
+ * @throws IllegalArgumentException if the rootdir cannot be found
+ */
+ public Path getRootdir() {
+ return new DefaultRootLocator().locateMandatoryRoot(basedir != null ?
basedir.toPath() : null);
+ }
Review Comment:
I think that's wrong. We should not be lazy here and the use of `new
DefaultRootLocator()` is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
