michael-o commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1163863120
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -116,6 +116,16 @@ default String getId() {
*/
boolean isRootProject();
+ /**
+ * Gets the root directory of the project, which is the parent directory
containing the {@code .mvn} directory
+ * or flagged with {@code root="true"}. If there's no such file, an {@code
IllegalStateException} will be thrown.
Review Comment:
The last sentence duplicates the `@throws`
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##########
@@ -101,6 +92,17 @@ public interface Session {
@Nonnull
Path getTopdir();
+ /**
+ * Gets the root directory of the session, which is the root directory for
the topdir project.
+ * If there's no such file, an {@code IllegalStateException} will be
thrown.
Review Comment:
same here
##########
maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -1679,4 +1681,13 @@ public ProjectBuildingRequest
getProjectBuildingRequest() {
public void setProjectBuildingRequest(ProjectBuildingRequest
projectBuildingRequest) {
this.projectBuilderConfiguration = projectBuildingRequest;
}
+
+ /**
+ * @since 4.0.0
+ * @return the rootdir for this project
+ * @throws IllegalArgumentException if the rootdir cannot be found
Review Comment:
Here it is IAE but else ISE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
