[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709768#comment-17709768
]
ASF GitHub Bot commented on MNG-7038:
-------------------------------------
gnodet commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1500587863
I think we should make the `rootdir` property available from the _project_
rather than from the _session_. If we want to support über-aggregations, we
should prepare for each project to have a different _rootdir_.
The current `session.rootdir` would only be the `rootdir` for the _top
project_.
Consider the following:
```
a
|- b
| \- c
\- d
\- e
```
where _b_ and _d_ are GitHub repositories and _a_ is a project aggregating
_b_ and _d_. In this case, _c_ rootdir should point to _b_ and _e_ rootdir
should point to _d_. If we don't do this, projects would be build differently
because the rootdir would point to _a_, which could be really bad.
I'm going to add a `getRootdir()` on `Project` and make sure that this one
is used when interpolating projects or injecting mojos. This would not affect
early usage of the `rootdir` property obviously.
The other possibility is to clearly document the limitation and that
projects using `rootdir` may not be properly aggregated (which is the case
currently for projects using the `maven.multiModuleProjectDirectory` or other
mechanisms), but if that could be fixed as well...
> Introduce public property to point to a root directory of (multi-module)
> project
> --------------------------------------------------------------------------------
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
> Issue Type: Improvement
> Reporter: Envious Guest
> Priority: Major
> Fix For: Issues to be reviewed for 4.x
>
>
> This is a request to expose a property *maven.multiModuleProjectDirectory*
> which is currently internal (or introduce a brand new one with analogous
> functionality).
> * For a single-module project, its value should be same as *project.basedir*
> * For multi-module project, its value should point to a project.basedir of a
> root module
> Example:
> multi-module // located at /home/me/sources
> +- module-a
> +- module B
> Sample multi-module/pom.xml:
> {{<project>}}
> {{ <parent>}}
> {{ <groupId>com.acme</groupId>}}
> {{ <artifactId>corp-parent</artifactId>}}
> {{ <version>1.0.0-RELEASE</version>}}
> {{ </parent>}}
> {{ <groupId>com.acme</groupId>}}
> {{ <artifactId>multi-module</artifactId>}}
> {{ <version>0.5.2-SNAPSHOT</version>}}
> {{ <modules>}}
> {{ <module>module-a</module>}}
> {{ <module>module-b</module>}}
> {{ </modules>}}
> {{</project>}}
> The property requested should return /home/me/sources/multi-module,
> regardless of whether it's referenced in any of the child modules (module-a,
> module-b) or in multi-module.
> Note that multi-module itself has parent (e.g. installed in a local
> repository), so the new property should be smart enough to detect it and
> still point to /home/me/sources/multi-module instead of the local repository
> where the corp-parent is installed.
> The use-case for such a property could be to have a directory for combined
> report of static analysis tools. Typical example - jacoco combined coverage
> reports.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
