gnodet commented on code in PR #1080: URL: https://github.com/apache/maven/pull/1080#discussion_r1157766172
########## maven-core/src/main/java/org/apache/maven/internal/StringUtils.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.internal; Review Comment: All inlined... ########## maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java: ########## @@ -89,10 +88,15 @@ public static String key(String groupId, String artifactId, String version) { } private static void notBlank(String str, String message) { - int c = str != null && str.length() > 0 ? str.charAt(0) : 0; - if ((c < '0' || c > '9') && (c < 'a' || c > 'z')) { - Validate.notBlank(str, message); + final int strLen = str != null ? str.length() : 0; Review Comment: I don't understand, you mean: ``` final int strLen = str != null && !str.isEmpty() ? str.length() : 0; ``` I kinda fail to see how adding an addition condition makes things more straightforward, but I guess that's a matter of taste, as a lot of things when we go to that level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
