[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707428#comment-17707428
]
Tim te Beek commented on MNG-6825:
----------------------------------
Opened another quick few pull requests to replace StringUtils, only there where
commons-lang3 was already a dependency:
[https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3Atimtebeek+archived%3Afalse+org%3Aapache]
Using these recipes:
[https://github.com/timtebeek/maven-rewrite/blob/main/string-utils.yml]
Wanted to discuss here how we want to approach updating projects that do not
already depend on commons-lang3: there's a total of 55 repositories using
either Plexus StringUtils or Maven shared StringUtils in the 89 Apache Maven
repositories scanned; details on this temporary link:
[https://public.moderne.io/results/lJnRe]
I fear it'll be too noisy and not go over well with individual project
maintainers if I were to create pull requests without some prior coordination
here. Can someone tell me what I should or should not do with regards to
further upgrades for this issue? Technically there's no limitations to create
more PRs, but we can't deny the human aspect around review & acceptance either.
:)
So far I'd created separate pull requests for StringUtils versus FileUtils &
IOUtils to make each small review easier, as requested previously; do we want
to continue with that approach also when that leads to dozens of pull requests
per use case?
Only when all three use cases have been replaced with commons-lang3 /
commons-io / commons-text can we evaluate if we can remove any of the plexus /
maven-shared dependencies, for another potential round of PRs to remove the
dependencies.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
