[
https://issues.apache.org/jira/browse/MNG-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703163#comment-17703163
]
ASF GitHub Bot commented on MNG-7738:
-------------------------------------
michael-o commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1143261715
##########
maven-core/src/main/java/org/apache/maven/toolchain/RequirementMatcherFactory.java:
##########
@@ -73,8 +73,6 @@ public boolean matches(String requirement) {
return range.getRecommendedVersion().compareTo(version) ==
0;
}
} catch (InvalidVersionSpecificationException ex) {
- // TODO error reporting
- ex.printStackTrace();
return false;
Review Comment:
If this information is required, it should be ad debug log level
##########
maven-core/src/test/java/org/apache/maven/repository/TestRepositorySystem.java:
##########
@@ -229,7 +229,7 @@ public ArtifactResolutionResult
resolve(ArtifactResolutionRequest request) {
.map(Dependency::new)
.collect(Collectors.toList());
} catch (IOException e) {
- e.printStackTrace();
Review Comment:
Same here
> Remove printStackTrace
> ----------------------
>
> Key: MNG-7738
> URL: https://issues.apache.org/jira/browse/MNG-7738
> Project: Maven
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Assignee: Elliotte Rusty Harold
> Priority: Minor
>
> There are multiple places in core where the code simply calls
> ex.printStackTrace() or equivalent, usually in a catch block, instead of
> going through the logging framework. This produces ugly, uncontrollable,
> often duplicate output. Remove or replace these.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
