michael-o commented on code in PR #129:
URL: https://github.com/apache/maven-archetype/pull/129#discussion_r1141326698
##########
archetype-common/src/main/java/org/apache/maven/archetype/creator/FilesetArchetypeCreator.java:
##########
@@ -391,10 +392,12 @@ else if ( !properties.containsKey( Constants.PACKAGE ) )
* Create the archetype project pom.xml file, that will be used to build
the archetype.
*/
private File createArchetypeProjectPom( MavenProject project,
ProjectBuildingRequest buildingRequest,
- Properties
configurationProperties, File projectDir )
+ Properties
configurationProperties, File projectDir,
+ String defaultEncoding )
throws TemplateCreationException, IOException
{
Model model = new Model();
+ model.getProperties().put( "project.build.sourceEncoding",
defaultEncoding );
Review Comment:
What if the input value is null or empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
