[
https://issues.apache.org/jira/browse/MNG-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702179#comment-17702179
]
ASF GitHub Bot commented on MNG-7743:
-------------------------------------
psiroky opened a new pull request, #1065:
URL: https://github.com/apache/maven/pull/1065
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Make the build work on JDK 20
> -----------------------------
>
> Key: MNG-7743
> URL: https://issues.apache.org/jira/browse/MNG-7743
> Project: Maven
> Issue Type: Task
> Components: Bootstrap & Build
> Reporter: Petr Široký
> Priority: Minor
>
> When building Maven (from master and 3.9.x branches) using the latest JDK 20
> RC (which is very likely going to be promoted to GA), I am seeing the
> following test error:
> {code:java}
> [ERROR]
> org.apache.maven.project.ProjectBuilderTest.testLocationTrackingResolution
> Time elapsed: 0.015 s <<< ERROR!
> java.lang.IllegalStateException: java.net.MalformedURLException: Illegal
> character found in host: '{'
> at
> org.apache.maven.repository.TestRepositoryConnector.<init>(TestRepositoryConnector.java:56)
> at
> org.apache.maven.repository.TestRepositoryConnectorFactory.newInstance(TestRepositoryConnectorFactory.java:39)
> at
> org.eclipse.aether.internal.impl.DefaultRepositoryConnectorProvider.newRepositoryConnector(DefaultRepositoryConnectorProvider.java:121)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:515)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:433)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
> at
> org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:242)
> at
> org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact(DefaultRepositorySystem.java:277)
> at
> org.apache.maven.project.ProjectModelResolver.resolveModel(ProjectModelResolver.java:167)
> at
> org.apache.maven.project.ProjectModelResolver.resolveModel(ProjectModelResolver.java:214)
> at
> org.apache.maven.project.ProjectModelResolver.resolveModel(ProjectModelResolver.java:279)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:1517)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:1339)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readEffectiveModel(DefaultModelBuilder.java:798)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:896)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:664)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:645)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:167)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:130)
> at
> org.apache.maven.AbstractCoreMavenComponentTestCase.createMavenSession(AbstractCoreMavenComponentTestCase.java:126)
> at
> org.apache.maven.AbstractCoreMavenComponentTestCase.createMavenSession(AbstractCoreMavenComponentTestCase.java:110)
> at
> org.apache.maven.AbstractCoreMavenComponentTestCase.createMavenSession(AbstractCoreMavenComponentTestCase.java:106)
> at
> org.apache.maven.project.ProjectBuilderTest.testLocationTrackingResolution(ProjectBuilderTest.java:357)
> ...
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
> Caused by: java.net.MalformedURLException: Illegal character found in host:
> '{'
> at java.base/java.net.URL.<init>(URL.java:798)
> at java.base/java.net.URL.<init>(URL.java:646)
> at java.base/java.net.URL.<init>(URL.java:582)
> at
> org.apache.maven.repository.TestRepositoryConnector.<init>(TestRepositoryConnector.java:54)
> ... 91 more
> Caused by: java.lang.IllegalArgumentException: Illegal character found in
> host: '{'
> at java.base/java.net.URLStreamHandler.setURL(URLStreamHandler.java:522)
> at
> java.base/java.net.URLStreamHandler.parseURL(URLStreamHandler.java:325)
> at java.base/sun.net.www.protocol.file.Handler.parseURL(Handler.java:56)
> at java.base/java.net.URL.<init>(URL.java:793)
> {code}
>
> This seems to be related to [https://bugs.openjdk.org/browse/JDK-8293590]
> which moved some of the URL validation to the constructor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
