w6et commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1474183673
> > > Do these three properties represent the same value?
> >
> >
> > I suppose you're talking about `topdir`, `project.topdir` and
`session.topdir` ? They are aliases, but I don't think the `project.topdir` is
a good idea, since it's not really a project attribute.
> > I'm still thinking about renaming the new property to `rootdir`, and
introduce a `topdir` for the execution directory in a consistent way. And
deprecate `MavenSession.getExecutionRootDirectory()`,
`MavenExecutionRequest.getBasedir()`,
`MavenExecutionRequest.getMultiModuleProjectDirectory()` accordingly. I'm open
to any naming, but things are a bit inconsistent, so I'd rather fix it.
>
> just another idea，Maybe we can define build.json(like npm's
package.json)，we can init topdir properties and other public properties in the
build.json，then generate build-lock.json\yaml, every module can use the
properties from build-lock.json, (BTW, maybe pom.xml->pom-lock.yaml，so only use
xxx-lock.yaml，so something don't need computed many times) maybe
dependencies、plugins、repositories ‘s properties can split to different
properties file，so we can import & share it for different maven project. or all
in build.json like `{ "name": "my app 001", "version": "0.0.1", "topdir":
"xxxxx", "mvn.properties": { "java.version":"17", "maven.test.skip":"true" },
"dependencies": { "compile": { "default":{ "default is required":"" },
"spring":{ "spring-amqp.version":"3.0.2" } } }, "plugins": {
>
> }, "repositories": {
>
> } } `
generated build-lock.json can contains system environment properties or
something else configuration ，so we can sure the actual
properties/configuration any which we used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
