[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #94: Use Maven Resolver

Tue, 14 Mar 2023 14:57:00 -0700 


michael-o commented on code in PR #94:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/94#discussion_r1136260250


##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java:
##########
@@ -560,39 +559,13 @@ private void populateModulesMenu(
         }
 
         // we require child modules and reactors to process module menu
-        if (project.getModules().size() > 0) {
+        List<MavenProject> projectModules = project.getCollectedProjects();

Review Comment:
   Just tried, this is truly wrong:
   
![grafik](https://user-images.githubusercontent.com/573017/225149386-e07df943-3815-462b-b68e-72b8f4c743a1.png)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to