[
https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697495#comment-17697495
]
ASF GitHub Bot commented on MNG-7720:
-------------------------------------
gnodet commented on code in PR #1038:
URL: https://github.com/apache/maven/pull/1038#discussion_r1128070377
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java:
##########
@@ -90,18 +89,17 @@ public
LifecycleDependencyResolver(ProjectDependenciesResolver projectDependenci
public static List<MavenProject> getProjects(MavenProject project,
MavenSession session, boolean aggregator) {
if (aggregator && project.getCollectedProjects() != null) {
- return
getProjectAndSubModules(project).collect(Collectors.toList());
+ List<MavenProject> downstreamProjects =
session.getProjectDependencyGraph()
+ .getDownstreamProjects(project, true); // sorted but more
than needed
+ List<MavenProject> collectedProjects =
project.getCollectedProjects(); // not sorted but what we need
Review Comment:
This should be
`getProjectAndSubModules(project).collect(Collectors.toList())` instead of
`project.getCollectedProjects()`, else the content will be very different.
The first one will return the project and all its submodules (recursively),
while the second will just return the modules of the current project.
> [REGRESSION] Build order is incorrect and does not respect Reactor Build Order
> ------------------------------------------------------------------------------
>
> Key: MNG-7720
> URL: https://issues.apache.org/jira/browse/MNG-7720
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
> Affects Versions: 3.9.0
> Reporter: Joe Littlejohn
> Assignee: Tamas Cservenak
> Priority: Blocker
> Fix For: 3.9.1
>
>
> I have a multi-module project. When using Maven 3.9.0, my project fails to
> build. The problem appears to be that the Reactor Build Order is not
> respected when the build actually runs.
> When the build runs, I see this output:
> {code:java}
> [INFO] Reactor Build Order:
> 15[INFO]
> 16[INFO] jsonschema2pojo
> [pom]
> 17[INFO] jsonschema2pojo-core
> [jar]
> 18[INFO] jsonschema2pojo-ant
> [jar]
> 19[INFO] jsonschema2pojo-cli
> [jar]
> 20[INFO] jsonschema2pojo-gradle-plugin
> [jar]
> 21[INFO] jsonschema2pojo-maven-plugin
> [maven-plugin]
> 22[INFO] jsonschema2pojo-integration-tests
> [jar] {code}
> However Maven first builds jsonschema2pojo, and next tries to build
> jsonschema2pojo-ant instead of jsonschema2pojo-core. The build fails because
> jsonschema2pojo-core is not found.
> There is a full log available here:
> https://github.com/joelittlejohn/jsonschema2pojo/actions/runs/4332878826/jobs/7565796916
> Workaround: Downgrade to Maven 3.8.7 and the problem goes away.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
