[
https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697116#comment-17697116
]
Stephen Crocker commented on MSKINS-97:
---------------------------------------
Its on Twitter Bootstrap v1, which is 10 years old. It underwent a huge API
rewrite to v2 and most the V2 documentation has disappeared.
I thought the logical step was migrating to v3 which is closer to v5 (largely
differences in css class names) but..
The problem I hit is bootstrap doesn't really have a concept as a Navigation
Bar on the side. The way to achieve it in Bootstrap 3 is completely different
to Bootstrap 5. So its easier to got straight to bootstrap 5.
The current library has copy pasted javascript files, the only one you need to
track down is the one which makes source code render blocks.
My suggestion:
* Follow the readme to construct all the test sites and take a screenshot so
you can compare.
* Then remove jQuery, etc.. from the project and purge the CSS (bootstrap no
longer needs jQuery and the CSS is not the right way to do it in bootstrap 5.
* Then upgrade the bootstrap js and CSS files to the latest.
* Then start by migrating everything to the bootstrap grid system, it doesn't
matter the parts arent rendering correctly, they they are in the right place.
* Then redo the horizontal navbar to align with bootstrap docs (and don't
forget the banner left/banner right parts of the spec).
* Then work to build a sidebar (that is a huge effort).
* Then complete the project version/date parts
* Then look at breadcrumbs
* Then all the deviations.
This skin attempts to exactly recreate the exist Maven 2 Site design, that was
made in 2010 and large chunks of it are considered bad/dated today. Those
deviations are largely where I got fed up.
I spent 4 days trying to get bootstrap-icon equivalents render like the
existing gifs and work under a responsive design knowing this team wouldbe
unhappy if it was missing.
I went off to make [Maven Site Bootstrap
skin|https://stevecrox.github.io/maven-site-bootstrap-skin/index.html], where
the goal was to create this but stick with standard bootstrap components and
try to limit custom config. I know the guy behind The [Maven Reflow
skin|https://devacfr.github.io/reflow-maven-skin/] felt similar to me, but what
I had done wasn't a good fit for his solution and I'd burnt myself out trying
to get some if this working. I still want to contribute to it though, that dude
was super nice and helpful
> Upgrade to Bootstrap 5.x
> ------------------------
>
> Key: MSKINS-97
> URL: https://issues.apache.org/jira/browse/MSKINS-97
> Project: Maven Skins
> Issue Type: Task
> Components: Fluido Skin
> Reporter: Michael Osipov
> Priority: Major
> Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png
>
>
> Next major of Fluido should be upgraded to Bootstrap 5.x which is *not*
> backwards compatible to 2.x. See http://getbootstrap.com/migration/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
