[
https://issues.apache.org/jira/browse/MSKINS-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533116#comment-17533116
]
Michael Osipov commented on MSKINS-174:
---------------------------------------
PR provided and tested against Jackrabbit site:
{noformat}
D:\Entwicklung\Projekte\jackrabbit-site> svn diff
Index: pom.xml
===================================================================
--- pom.xml (revision 1900636)
+++ pom.xml (working copy)
@@ -60,6 +60,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
+ <version>3.12.0</version>
<configuration>
<skipDeploy>true</skipDeploy>
<generateReports>true</generateReports>
@@ -70,7 +71,7 @@
<dependency>
<groupId>org.apache.maven.doxia</groupId>
<artifactId>doxia-module-markdown</artifactId>
- <version>1.9.1</version>
+ <version>1.11.1</version>
</dependency>
</dependencies>
</plugin>
Index: src/site/site.xml
===================================================================
--- src/site/site.xml (revision 1900636)
+++ src/site/site.xml (working copy)
@@ -22,7 +22,7 @@
xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.0
http://maven.apache.org/xsd/decoration-1.8.0.xsd";
name="Apache Jackrabbit">
<version position="none"/>
- <publishDate position="left"/>
+ <publishDate position="bottom"/>
<body>
<menu name="Apache Jackrabbit">
<item name="Welcome" href="index.html"/>
@@ -91,7 +91,7 @@
<skin>
<groupId>org.apache.maven.skins</groupId>
<artifactId>maven-fluido-skin</artifactId>
- <version>1.9</version>
+ <version>1.11.0-SNAPSHOT</version>
</skin>
<custom>
{noformat}
> Render breadcrumbs div conditionally
> ------------------------------------
>
> Key: MSKINS-174
> URL: https://issues.apache.org/jira/browse/MSKINS-174
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.9
> Reporter: Konrad Windszus
> Assignee: Michael Osipov
> Priority: Major
> Fix For: fluido-1.11.0
>
> Attachments: breadcrumb-div.png
>
>
> Currently the breadcrumb div is always rendered even if it is empty
> (https://github.com/apache/maven-fluido-skin/blob/dda45e9236f90dc8493fcc917a99716212825573/src/main/resources/META-INF/maven/site.vm#L202).
> That leads to the issue that a grey bar is rendered in case the publish date
> is not rendered at the top (left or right): !breadcrumb-div.png!
> That div should be rendered only conditionally in case there is
> # at least one breadcrumb item or
> # the publish date is positioned "left" or "right"
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
