jainankitk commented on code in PR #15149:
URL: https://github.com/apache/lucene/pull/15149#discussion_r2331585171
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90NormsProducer.java:
##########
@@ -394,6 +394,14 @@ public long longValue() throws IOException {
public long longValue() throws IOException {
return slice.readByte(doc);
}
+
+ @Override
+ public void longValues(int size, int[] docs, long[] values, long
defaultValue)
+ throws IOException {
+ // Delegate to help performance: when the super call inlines,
calls to
+ // #advanceExact/#longValue become monomorphic.
Review Comment:
Yeah, it was to update the comment. I was initially confused by the
sub/super class, but this is the subclass so `delegate` does make sense.
> The JVM gives no guarantees about what may inline or not
With some of these recent optimizations around inlining, I am wondering how
do we know that we are getting the optimal performance or not. Is there a way
to instrument the code in a manner that provides signal if a particular
optimization is being leveraged or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
