shatejas commented on code in PR #13985:
URL: https://github.com/apache/lucene/pull/13985#discussion_r2271691227
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java:
##########
@@ -250,6 +262,13 @@ public RandomVectorScorer getRandomVectorScorer(String
field, byte[] target) thr
target);
}
+ @Override
+ public void finishMerge() throws IOException {
+ // This makes sure that the access pattern hint is reverted back since
HNSW implementation
+ // needs it
+ this.vectorData.updateReadAdvice(ReadAdvice.RANDOM);
Review Comment:
> Directory and its hints and iocontexts and sysprops and so on. But I don't
think we currently have IOContext.getReadAdvice()?
At the time of the change the initial advice was random so this is reverting
back to random. But I agree, we can simply cache it and revert it from the
cached value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
