dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085278571
##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+ assert project.java.sourceCompatibility ==
project.java.targetCompatibility
+
// Compilation environment.
- // we use -source/-target as it is significantly faster than --release
Review Comment:
I would be actually more keen on using explicit source/target/release
options - much easier to understand when you're debugging options at some
point. The major problem is that this "compliance" you switched to is actually
using the release flag, which - according to the comment above - used to be
much slower than just source/target (we did have it at some point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
