ChrisHegarty commented on code in PR #14604:
URL: https://github.com/apache/lucene/pull/14604#discussion_r2081375455
##########
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##########
@@ -136,7 +137,8 @@ public class MMapDirectory extends FSDirectory {
private BiFunction<String, IOContext, Optional<ReadAdvice>>
readAdviceOverride =
(_, _) -> Optional.empty();
- private BiPredicate<String, IOContext> preload = NO_FILES;
+ private BiFunction<String, IOContext, Optional<Boolean>> preloadOverride =
+ (_, _) -> Optional.empty();
Review Comment:
Oh, I see that we enable preLoad by hints by default. I was not expecting
this. Since it's trivial to enable, and preLoad was opt-in previously, can we
restore that behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
