mikemccand commented on code in PR #14443:
URL: https://github.com/apache/lucene/pull/14443#discussion_r2070345447
##########
lucene/core/src/java/org/apache/lucene/search/SearcherManager.java:
##########
@@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader,
SearcherFactory searcherFactory)
this.current = getSearcher(searcherFactory, reader, null);
}
+ /** Set supplier for selecting commits to refresh on */
+ public void setRefreshCommitSupplier(RefreshCommitSupplier
refreshCommitSupplier) {
Review Comment:
Should this maybe be passed to ctor instead? (And we'd add another
telescoping ctor). Typically one would not need to change this after creating
the `SearcherManager`?
##########
lucene/core/src/java/org/apache/lucene/search/SearcherManager.java:
##########
@@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader,
SearcherFactory searcherFactory)
this.current = getSearcher(searcherFactory, reader, null);
}
+ /** Set supplier for selecting commits to refresh on */
+ public void setRefreshCommitSupplier(RefreshCommitSupplier
refreshCommitSupplier) {
+ this.refreshCommitSupplier = refreshCommitSupplier;
+ }
+
@Override
protected void decRef(IndexSearcher reference) throws IOException {
reference.getIndexReader().decRef();
}
+ /** Return index commit generation for current searcher */
+ public long getSearcherCommitGeneration() throws IOException {
Review Comment:
I wonder if we should leave this to caller?
It's a bit dangerous to provide such a method because if a refresh happens
concurrently, the returned `gen` might be stale by the time caller does
something with it? Though of course the app would presumably "know" if it has
a background refresh thread ...
##########
lucene/core/src/java/org/apache/lucene/search/RefreshCommitSupplier.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.search;
+
+import java.io.IOException;
+import org.apache.lucene.index.DirectoryReader;
+import org.apache.lucene.index.IndexCommit;
+
+/**
+ * Expert: Interface to supply commit for searcher refresh.
+ *
+ * @lucene.experimental
+ */
+public interface RefreshCommitSupplier {
Review Comment:
If we don't like the added API surface area of a new `interface`, we could
maybe un-final `SearcherManager` and allow subclass to override the default of
picking the latest `IndexCommit`? I don't really have a preference... the new
interface is `@lucene.experimental` so we are free to evolve it, even within
stable release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
