jpountz commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2056150570
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##########
@@ -53,11 +65,30 @@ public LeafCollector getLeafCollector(LeafReaderContext
context) throws IOExcept
// The segment has no values, nothing to do.
throw new CollectionTerminatedException();
}
+
+ // We can use multi range traversal logic to collect the histogram on
numeric
+ // field indexed as point for MATCH_ALL cases. In future, this can be
extended
+ // for Point Range Query cases as well
+ if (query instanceof MatchAllDocsQuery && context.reader().hasDeletions()
== false) {
Review Comment:
I'ml not sure if we're talking about the same case. You seem to be talking
about the case when the histogram is computed on the same field as the range
query. I was referring to the case when a query is not a `MatchAllDocsQuery`
but still fully matches a segment, e.g. a `TermQuery` on a stop word like `a`
or a wide `PointRangeQuery` (not necessarily on the same field as the
histogram).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
