dweiss commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2054473882


##########
lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java:
##########
@@ -810,10 +810,7 @@ public MergeSpecification findMerges(CodecReader... 
readers) throws IOException
     }
     for (MergePolicy.OneMerge merge : merges) {
       if (merge.getMergeInfo() != null) {
-        assertFalse(
-            Arrays.stream(c.destDir.listAll())
-                .collect(Collectors.toSet())
-                .containsAll(merge.getMergeInfo().files()));
+        
assertFalse(Set.of(c.destDir.listAll()).containsAll(merge.getMergeInfo().files()));

Review Comment:
   So, yes, it's all subjective. The previous version had stream methods over 
multiple lines - to me that read easier compared to the one-liner now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to