rmuir commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2054468730
##########
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##########
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract long fileLength(String name) throws IOException;
+ protected void validateIOContext(IOContext context) {
Review Comment:
I see this method being used, but I don't understand what it is doing. Why
is explicit validation needed, and when should subclasses be invoking this
method?
Could the validation be moved to IOContext itself, e.g. into IOContext ctor
to prevent that "invalid" IOContexts ever get created in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
