benwtrent commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2050897977
##########
lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java:
##########
@@ -203,7 +203,8 @@ protected final int slowAdvance(int target) throws
IOException {
* @lucene.internal
*/
public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws
IOException {
- assert offset <= docID();
+ assert offset <= docID() && offset <= upTo
Review Comment:
```
2> abr. 18, 2025 7:45:04 DA TARDE
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
uncaughtException
2> WARNING: Uncaught exception in thread:
Thread[#786,Thread-718,5,TGRP-TestLucene99PostingsFormat]
2> java.lang.RuntimeException: java.lang.AssertionError: offset=2147483133
docID()=2147483647 upTo=-2147483636
2> at __randomizedtesting.SeedInfo.seed([27691DDFD301323F]:0)
2> at
[email protected]/org.apache.lucene.tests.index.RandomPostingsTester$TestThread.run(RandomPostingsTester.java:1448)
2> Caused by: java.lang.AssertionError: offset=2147483133
docID()=2147483647 upTo=-2147483636
2> at
[email protected]/org.apache.lucene.search.DocIdSetIterator.intoBitSet(DocIdSetIterator.java:207)
2> at
[email protected]/org.apache.lucene.tests.index.RandomPostingsTester.verifyEnum(RandomPostingsTester.java:1399)
2> at
[email protected]/org.apache.lucene.tests.index.RandomPostingsTester.testTermsOneThread(RandomPostingsTester.java:1605)
2> at
[email protected]/org.apache.lucene.tests.index.RandomPostingsTester$TestThread.run(RandomPostingsTester.java:1445)
2>
```
This is some of the test failures. That seems weird to me. Isn't this
obvious input garbage indicating some iteration failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
