jpountz commented on code in PR #14448:
URL: https://github.com/apache/lucene/pull/14448#discussion_r2031612400
##########
lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorable.java:
##########
@@ -44,7 +44,7 @@ public void setMinCompetitiveScore(float minScore) throws
IOException {
}
public static Scorable wrap(Scorable in) {
- if (in instanceof AssertingScorable) {
+ if (in instanceof WrappedScorer || in instanceof AssertingScorable) {
Review Comment:
I don't understand this part of the change, this method expects the returned
`Scorable` to have assertions enabled, but it may not be the case if this is an
instance of `WrappedScorer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
