jainankitk commented on code in PR #14452:
URL: https://github.com/apache/lucene/pull/14452#discussion_r2032123491
##########
lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorer.java:
##########
@@ -80,8 +74,8 @@ boolean iterating() {
@Override
public void setMinCompetitiveScore(float score) throws IOException {
- assert scoreMode == ScoreMode.TOP_SCORES;
- assert canCallMinCompetitiveScore;
+ assert canScore;
+ assert canSetMinCompetitiveScore;
Review Comment:
Still trying to understand this code better, but it seems that the assertion
statement is weaker now. Earlier, it was specifically `scoreMode ==
ScoreMode.TOP_SCORES`, and now it is `scoreMode.needsScores()`. Do we allow it
for other `scoreMode` that `needsScores` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
