cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778254222
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/Lucene94HnswVectorsReader.java:
##########
@@ -283,11 +289,17 @@ public void search(String field, float[] target,
KnnCollector knnCollector, Bits
scorer,
new OrdinalTranslatedKnnCollector(knnCollector,
vectorValues::ordToDoc),
getGraph(fieldEntry),
- vectorValues.getAcceptOrds(acceptDocs));
+ vectorValues.getAcceptOrds(acceptDocs),
+ seedDocs);
Review Comment:
This question is perhaps a side effect of the history of this pull request
and/or a naive question on my part: when do and don't we change the
implementation of classes in the `backwards_codecs` (implementation other than
signature) -- I note that here for 94 and 95 there are changes but for 92 there
is no change. and 99 has no change (as yet). My speculation (but it is only
that) is that perhaps the 94 and 95 changes need to move to 99 and that
anything in `backwards_codecs` would get the method signature change only but
no implementation change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
