romseygeek commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750548459
##########
lucene/monitor/src/java/org/apache/lucene/monitor/CollectingMatcher.java:
##########
@@ -37,7 +38,7 @@ abstract class CollectingMatcher<T extends QueryMatch>
extends CandidateMatcher<
@Override
public void matchQuery(final String queryId, Query matchQuery, Map<String,
String> metadata)
throws IOException {
- searcher.search(matchQuery, new MatchCollector(queryId, scoreMode));
+ searcher.search(matchQuery, CollectorManager.wrap(new
MatchCollector(queryId, scoreMode)));
Review Comment:
I think we can make the public-facing methods all take `DocumentBatch` here
rather than `IndexSearcher`, which will make building the index searcher an
implementation detail. I'll put together a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
