gsmiller commented on code in PR #13737:
URL: https://github.com/apache/lucene/pull/13737#discussion_r1747783583
##########
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##########
@@ -54,4 +79,167 @@ public ReducedFacetsCollector(final
Collection<FacetsCollector> facetsCollectors
facetsCollector ->
matchingDocs.addAll(facetsCollector.getMatchingDocs()));
}
}
+
+ /** Utility method, to search and also collect all hits into the provided
{@link Collector}. */
Review Comment:
Shoot, I think I missed this in the earlier review but looks like we need a
small javadoc cleanup here (need to mention `FacetsCollectorManager` instead of
`Collector` right?). Same comment applies to all the new methods. Sorry for
overlooking that.
I just updated these on `main` with a quick commit
(dc47adbbe736ef55f56feb8d66dc768eaba05fff). Could you cherry-pick this down
into the back-port as well (and feel free to tweak the language if you think of
ways to improve on it). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
