cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1707421233
##########
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##########
@@ -156,6 +196,44 @@ private TopDocs getLeafResults(
}
}
+ private DocIdSetIterator executeSeedQuery(LeafReaderContext ctx, Weight
seedWeight)
+ throws IOException {
+ if (seedWeight != null) {
+ // Execute the seed query
+ TopScoreDocCollector seedCollector =
+ new TopScoreDocCollectorManager(k, Integer.MAX_VALUE).newCollector();
Review Comment:
Wondering if we could use a lower `totalHitsThreshold` here since
`seedCollector.topDocs().totalHits` seems to be unused?
```suggestion
new TopScoreDocCollectorManager(k, k).newCollector();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
