jpountz commented on code in PR #13610:
URL: https://github.com/apache/lucene/pull/13610#discussion_r1696951086
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/FieldReader.java:
##########
@@ -100,6 +99,14 @@ public final class FieldReader extends Terms {
w.close();
}
*/
+ BytesRef emptyOutput = metadata.getEmptyOutput();
+ if (rootCode.equals(emptyOutput) == false) {
+ // TODO: this branch is never taken?
Review Comment:
Nit: Remove the question mark, which suggests we're not sure, while both the
code and Mike suggest that they are indeed always the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
