javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1690239008
##########
lucene/core/src/test/org/apache/lucene/search/TestSortRandom.java:
##########
@@ -119,7 +119,8 @@ private void testRandomStringSort(SortField.Type type)
throws Exception {
System.out.println(" reader=" + r);
}
- final IndexSearcher s = newSearcher(r, false);
+ // TODO this needs investigation, it fails with concurrency enabled (seed:
393E6798D70D742D)
+ final IndexSearcher s = newSearcher(r, false, random.nextBoolean(), false);
Review Comment:
I do see the reason for the failure now, the custom query this test relies
on makes assumptions about the scorer supplier being called once per
LeafReaderContext. That would be addressed by removing work duplication across
partitions of the same segment. Otherwise we do segment level work once per
partition, instead of doing it once and sharing the result. Also, depending on
the implementation, we may also multiply results in that we would go over the
same segment multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
