uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1683116076
##########
lucene/core/src/java/org/apache/lucene/index/IndexFileNames.java:
##########
@@ -142,6 +143,26 @@ public static String stripSegmentName(String filename) {
return filename;
}
+ /**
Review Comment:
In fact we could add some logic to place all files with a generation
number!=0 (or none at all) in a single arena. Of course it would cause that
files in that arena are never unmapped unless the last file is closed. This
happens of course if the index segment is closed, but it might indeed be a good
idea to limit arena reuse. If acquire returns false we could instruct the code
to generate a new arena and remove the old one from the concurrent map (so it
won't be reused anymore). It would free itsself after the last file is closed,
but new files would be in the new arena.
Nice idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
