ChrisHegarty commented on code in PR #13578:
URL: https://github.com/apache/lucene/pull/13578#discussion_r1680862628
##########
lucene/test-framework/src/java/org/apache/lucene/tests/store/MockDirectoryWrapper.java:
##########
@@ -814,6 +814,14 @@ public synchronized IndexInput openInput(String name,
IOContext context) throws
context = LuceneTestCase.newIOContext(randomState, context);
final boolean confined = context == IOContext.READONCE;
Review Comment:
The failure is because of a use of `READ` rather than `READONCE` when
checksumming a segments file in `SegmentInfos::readCommit`. So, the new check
in the MockDirectoryWrapper is working as expected - finding a really problem.
Orthogonally, we could expand the check as you suggested, but it is not
strictly necessary here, unless you think that it should be done anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
