uschindler commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1679766918
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java:
##########
@@ -125,4 +134,31 @@ private final MemorySegment[] map(
}
return segments;
}
+
+ public ConcurrentHashMap<String, RefCountedSharedArena> attachment() {
+ return new ConcurrentHashMap<>();
+ }
+
+ /**
+ * Gets an arena for the give path, potentially aggregating files from the
same segment into a
+ * single ref counted shared arena. A ref counted shared arena, if created
will be added to the
+ * given arenas map.
+ */
+ static Arena getSharedArena(Path p, ConcurrentHashMap<String,
RefCountedSharedArena> arenas) {
+ String filename = p.getFileName().toString();
+ String segmentName = IndexFileNames.parseSegmentName(filename);
+ if (filename.length() == segmentName.length()) {
+ // no segment found; just use a shared segment
+ return Arena.ofShared();
Review Comment:
P.S.: For known files like `segments_*` that are definitely READONCE we
added a check in https://github.com/apache/lucene/pull/13574. Those are opened
with READONCE semantics and MMapDir will use a confined segment.
So unless we have some other files which are not belonging to segments, this
case here should happen seldom (only for custom index files added by extra
codecs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
