Shradha26 commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1679689124


##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/package-info.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/**
+ * Sandbox faceting - Collectors that compute facets. Facet Ordinals/Ids: Each 
doc may have
+ * different facets and therefore, different facet ordinals. For example a 
book can have Author,
+ * Publish Date, Page Count etc. as facets. The specific value for each of 
these Facets for a book
+ * can be mapped to an ordinal. Facet Ids may be common across different book 
documents.
+ * FacetCutter: Can interpret Facets of a specific type for a doc type and 
output all the Facet
+ * Ordinals for the type for the doc. Facet Recorders: record data per 
ordinal. Some recorders may
+ * compute aggregations and record per ordinal data aggregated across an index.

Review Comment:
   It's not necessary for FacetRecorders to compute aggregations. They can hold 
any data per facet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to