epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1678185585
##########
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##########
@@ -398,130 +497,56 @@ private <R> ConcurrentDrillSidewaysResult<R>
searchSequentially(
}
Query[] drillDownQueries = query.getDrillDownQueries();
- int numDims = drillDownDims.size();
-
- FacetsCollectorManager drillDownCollectorManager =
createDrillDownFacetsCollectorManager();
-
- FacetsCollectorManager[] drillSidewaysFacetsCollectorManagers =
- new FacetsCollectorManager[numDims];
- for (int i = 0; i < numDims; i++) {
- drillSidewaysFacetsCollectorManagers[i] =
createDrillSidewaysFacetsCollectorManager();
- }
-
DrillSidewaysQuery dsq =
new DrillSidewaysQuery(
baseQuery,
- drillDownCollectorManager,
- drillSidewaysFacetsCollectorManagers,
+ // drillDownCollectorOwner,
+ // Don't pass drill down collector because drill down is collected
by IndexSearcher
+ // itself.
+ // TODO: deprecate drillDown collection in DrillSidewaysQuery?
+ null,
+ drillSidewaysCollectorOwners,
drillDownQueries,
scoreSubDocsAtOnce());
- R collectorResult = searcher.search(dsq, hitCollectorManager);
-
- FacetsCollector drillDownCollector;
- if (drillDownCollectorManager != null) {
- drillDownCollector =
drillDownCollectorManager.reduce(dsq.managedDrillDownCollectors);
- } else {
- drillDownCollector = null;
- }
-
- FacetsCollector[] drillSidewaysCollectors = new FacetsCollector[numDims];
- int numSlices = dsq.managedDrillSidewaysCollectors.size();
-
- for (int dim = 0; dim < numDims; dim++) {
- List<FacetsCollector> facetsCollectorsForDim = new
ArrayList<>(numSlices);
-
- for (int slice = 0; slice < numSlices; slice++) {
-
facetsCollectorsForDim.add(dsq.managedDrillSidewaysCollectors.get(slice)[dim]);
- }
-
- drillSidewaysCollectors[dim] =
-
drillSidewaysFacetsCollectorManagers[dim].reduce(facetsCollectorsForDim);
- }
-
- String[] drillSidewaysDims = drillDownDims.keySet().toArray(new String[0]);
-
- return new ConcurrentDrillSidewaysResult<>(
- buildFacetsResult(drillDownCollector, drillSidewaysCollectors,
drillSidewaysDims),
- null,
- collectorResult,
- drillDownCollector,
- drillSidewaysCollectors,
- drillSidewaysDims);
+ searcher.searchNoReduce(dsq, drillDownCollectorOwner);
}
- @SuppressWarnings("unchecked")
- private <R> ConcurrentDrillSidewaysResult<R> searchConcurrently(
- final DrillDownQuery query, final CollectorManager<?, R>
hitCollectorManager)
+ private void searchConcurrently(
+ final DrillDownQuery query,
+ final CollectorOwner<?, ?> drillDownCollectorOwner,
+ final List<CollectorOwner<?, ?>> drillSidewaysCollectorOwners)
throws IOException {
final Map<String, Integer> drillDownDims = query.getDims();
final List<CallableCollector> callableCollectors = new
ArrayList<>(drillDownDims.size() + 1);
- // Add the main DrillDownQuery
- FacetsCollectorManager drillDownFacetsCollectorManager =
- createDrillDownFacetsCollectorManager();
- CollectorManager<?, ?> mainCollectorManager;
- if (drillDownFacetsCollectorManager != null) {
- // Make sure we populate a facet collector corresponding to the base
query if desired:
- mainCollectorManager =
- new MultiCollectorManager(drillDownFacetsCollectorManager,
hitCollectorManager);
- } else {
- mainCollectorManager = hitCollectorManager;
- }
- callableCollectors.add(new CallableCollector(-1, searcher, query,
mainCollectorManager));
+ callableCollectors.add(new CallableCollector(-1, searcher, query,
drillDownCollectorOwner));
int i = 0;
final Query[] filters = query.getDrillDownQueries();
- for (String dim : drillDownDims.keySet())
+ for (String dim : drillDownDims.keySet()) {
callableCollectors.add(
new CallableCollector(
- i++,
+ i,
searcher,
getDrillDownQuery(query, filters, dim),
- createDrillSidewaysFacetsCollectorManager()));
-
- final FacetsCollector mainFacetsCollector;
- final FacetsCollector[] facetsCollectors = new
FacetsCollector[drillDownDims.size()];
- final R collectorResult;
+ drillSidewaysCollectorOwners.get(i)));
+ i++; // TODO: refactor maybe?
Review Comment:
Ah yes, I think we can just remove the TODO - don't remember what
refactoring I had in mind TBH.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
