uschindler commented on code in PR #13535:
URL: https://github.com/apache/lucene/pull/13535#discussion_r1665836026


##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -591,15 +611,17 @@ MemorySegmentIndexInput buildSlice(String 
sliceDescription, long offset, long le
           null, // clones don't have an Arena, as they can't close)
           slices[0].asSlice(offset, length),
           length,
-          chunkSizePower);
+          chunkSizePower,
+          confined);

Review Comment:
   passing here confined for the slice looks correct, because this would 
disallow clones of possible slices.
   
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to