ChrisHegarty commented on PR #13535: URL: https://github.com/apache/lucene/pull/13535#issuecomment-2203199663
> Cool. Seems useful to achieve the goal. > > As written in the original issue maybe we should disallow clones, random access and slices of IndexInput on top of that. This may allow us to find more bugs. Yeah, we can either pass in a boolean, or something based on `MemorySegment::isAccessibleBy`. The former seems more straightforward, while the latter seems more flexible to allow slices, etc, but just for the calling thread. But that seems likely incorrect usage and not something we need to add complexity for. > In general we should document thois somehow on the methods in the base class Directory that the IOContext has implications on usage from multiple threads. ++ I'll see if I can find, at least, some minimal wording that we can add here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
