stefanvodita commented on code in PR #13494:
URL: https://github.com/apache/lucene/pull/13494#discussion_r1642852951
##########
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java:
##########
@@ -154,7 +154,7 @@ public FacetResult getAllChildren(String dim, String...
path) throws IOException
final BytesRef term = docValues.lookupOrd(sparseCount.key);
labelValues.add(new LabelAndValue(term.utf8ToString(), count));
}
- } else {
Review Comment:
On running the test, I see we're actually going through the case at [line
102](https://github.com/apache/lucene/blob/d29c57e50c38c1a090395644165b34f5191246b8/lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java#L102).
Hmm, need to think a bit more about what the best solution is here. Not that
the existing one doesn't work too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
