gf2121 commented on code in PR #13424:
URL: https://github.com/apache/lucene/pull/13424#discussion_r1618303808
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java:
##########
@@ -609,6 +622,23 @@ public void skipBytes(long numBytes) throws IOException {
}
}
+ @Override
+ public void prefetch(int docID) throws IOException {
+ final long blockID = indexReader.getBlockID(docID);
+
+ for (long prefetchedBlockID : prefetchedBlockIDCache) {
+ if (prefetchedBlockID == blockID) {
+ return;
+ }
+ }
+
+ final long blockStartPointer = indexReader.getBlockStartPointer(blockID);
+ final long blockLength = indexReader.getBlockLength(blockID);
+ fieldsStream.prefetch(blockStartPointer, blockLength);
+
+ prefetchedBlockIDCache[prefetchedBlockIDCacheIndex++ &
PREFETCH_CACHE_MASK] = blockID;
Review Comment:
It seems `prefetchedBlockIDCacheIndex` may overflow if a instance has too
many `prefetch` calls. Let's keep it small ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
