uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611267014
##########
lucene/test-framework/src/java/module-info.java:
##########
@@ -19,6 +19,7 @@
@SuppressWarnings({"module", "requires-automatic",
"requires-transitive-automatic"})
module org.apache.lucene.test_framework {
uses org.apache.lucene.codecs.KnnVectorsFormat;
+ uses org.apache.lucene.index.VectorSimilarityFunction;
Review Comment:
if you are on it, please also remove the ServiceLoader usage in
LuceneTestCase that introduces the KnnVectorsFormat here, too.
In general both should have a method to list all available
formats/simliarities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
