uschindler commented on code in PR #13339:
URL: https://github.com/apache/lucene/pull/13339#discussion_r1607992706
##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorizationProvider.java:
##########
@@ -73,4 +75,9 @@ private static <T> T doPrivileged(PrivilegedAction<T> action)
{
public VectorUtilSupport getVectorUtilSupport() {
return vectorUtilSupport;
}
+
+ @Override
+ public FlatVectorsScorer newFlatVectorScorer() {
Review Comment:
In my opinion, this one could also return a static/stateless instance like
VectorUtilSupport. Maybe rename getFlatVectorScorer?
Or do we plan to have state in those implementations?
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/DefaultVectorizationProvider.java:
##########
@@ -30,4 +33,9 @@ final class DefaultVectorizationProvider extends
VectorizationProvider {
public VectorUtilSupport getVectorUtilSupport() {
return vectorUtilSupport;
}
+
+ @Override
+ public FlatVectorsScorer newFlatVectorScorer() {
Review Comment:
same here!
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -91,6 +92,8 @@ public static VectorizationProvider getInstance() {
*/
public abstract VectorUtilSupport getVectorUtilSupport();
+ public abstract FlatVectorsScorer newFlatVectorScorer();
Review Comment:
as this may return a static, stateless instance we could rename this to
`getFlatVectorScorer()`. It does not need to create new instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
