ChrisHegarty commented on PR #13351:
URL: https://github.com/apache/lucene/pull/13351#issuecomment-2102304137
There is a problem with `default` - it does not do what you might expect it
to do - it does not enable Panama Vector (unless you prevent C2 from being
disabled). For example:
```
$ ./gradlew :lucene:core:test --tests
TestKnnByteVectorQuery.testVectorEncodingMismatch -Ptests.vectorsize="default"
-Ptests.forceintegervectors=false --info
...
org.apache.lucene.search.TestKnnByteVectorQuery > testVectorEncodingMismatch
STANDARD_ERROR
M5 09, 2024 3:26:42 KANG’AMA
org.apache.lucene.internal.vectorization.VectorizationProvider lookup
WARNING: C2 compiler is disabled; Java vector incubator API can't be
enabled
...
```
The addition of `default` is opportunistic while we are here, but the
fundamental value add of this PR is to add a way to more easily run with the
"real world" vector similarities, which we can do with
`tests.defaultvectorization`. Let's revert the addition of `default`. It's not
adding any real value here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
