uschindler commented on code in PR #13351:
URL: https://github.com/apache/lucene/pull/13351#discussion_r1594041203
##########
gradle/testing/randomization.gradle:
##########
@@ -107,10 +107,14 @@ allprojects {
// vectorization related
[propName: 'tests.vectorsize',
value: { ->
- RandomPicks.randomFrom(new Random(projectSeedLong), ["128",
"256", "512"])
+ isCIBuild ? "" : RandomPicks.randomFrom(new
Random(projectSeedLong), ["", "128", "256", "512"])
Review Comment:
we can also set it to `null` which will not pass the property at all.
Currently the code in VectorizationProvider looks like this:
https://github.com/apache/lucene/blob/06973f5723e97de7b73a84b1ff3c8c35db79d7ec/lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java#L46-L57
We can change the "isEmpty" line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
