Pulkitg64 commented on code in PR #13308:
URL: https://github.com/apache/lucene/pull/13308#discussion_r1573864798
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java:
##########
@@ -302,7 +301,6 @@ private static VectorSimilarityFunction
getDistFunc(IndexInput input, byte b) th
List.of(
VectorSimilarityFunction.EUCLIDEAN,
VectorSimilarityFunction.DOT_PRODUCT,
- VectorSimilarityFunction.COSINE,
Review Comment:
Thanks @uschindler @ChrisHegarty for the pointers, but IIUC, we cannot add
a null entry to VectorSimilarityFunction map for COSINE in these files because
we still want to use COSINE similarity function for Lucene versions < 10.0,
right? Please correct me if I am wrong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
