vigyasharma commented on code in PR #13311:
URL: https://github.com/apache/lucene/pull/13311#discussion_r1569337501
##########
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##########
@@ -781,7 +781,7 @@ public void testTimeLimitingKnnCollectorManager() throws
IOException {
TimeLimitingKnnCollectorManager noTimeoutManager =
new TimeLimitingKnnCollectorManager(delegate, null);
KnnCollector noTimeoutCollector =
- noTimeoutManager.newCollector(Integer.MAX_VALUE,
searcher.leafContexts.getFirst());
+ noTimeoutManager.newCollector(Integer.MAX_VALUE,
searcher.leafContexts.get(0));
Review Comment:
What is our preferred approach for handling such compilation issues during
backport? I was worried about recurring conflicts if we just change it in
branch_9x, is that not the case? Skipping backport for something like this
didn't seem right either. I'd like to learn what we consider as good practice
for Lucene codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
