dweiss commented on code in PR #13312:
URL: https://github.com/apache/lucene/pull/13312#discussion_r1568342142
##########
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##########
@@ -784,7 +785,9 @@ public void testTimeLimitingKnnCollectorManager() throws
IOException {
noTimeoutManager.newCollector(Integer.MAX_VALUE,
searcher.leafContexts.getFirst());
// Check that a normal collector is created without timeout
- assertTrue(noTimeoutCollector instanceof TopKnnCollector);
+ assertTrue(
Review Comment:
Thanks for trying to fix this. I think this type of test is problematic in
that it restricts the implementations that are, in theory, an open set... I
would change the implementation returned inside TimeLimitingKnnCollectorManager
to a package-private class, then check for that using
assertFalse(noTimeoutCollector instanceof
TimeLimitingKnnCollectorManager.TimeoutingKnnCollector)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
