shubhamvishu commented on code in PR #13124:
URL: https://github.com/apache/lucene/pull/13124#discussion_r1506927786
##########
lucene/core/src/java/org/apache/lucene/index/SegmentMerger.java:
##########
@@ -56,13 +58,19 @@ final class SegmentMerger {
InfoStream infoStream,
Directory dir,
FieldInfos.FieldNumbers fieldNumbers,
- IOContext context)
+ IOContext context,
+ Executor parallelMergeTaskExecutor)
throws IOException {
if (context.context != IOContext.Context.MERGE) {
throw new IllegalArgumentException(
"IOContext.context should be MERGE; got: " + context.context);
}
- mergeState = new MergeState(readers, segmentInfo, infoStream);
+ mergeState =
+ new MergeState(
+ readers,
+ segmentInfo,
+ infoStream,
+ parallelMergeTaskExecutor == null ? null : new
TaskExecutor(parallelMergeTaskExecutor));
Review Comment:
> it's a bit weird to use a class from the search package for merging
(TaskExecutor)
+1 ...... @jpountz since now we are using `TaskExecutor` on both search and
indexing use cases does it make sense to move it into `org.apache.lucene.util`
package maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
