dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486545976
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##########
@@ -47,25 +47,64 @@
public abstract class BackwardsCompatibilityTestBase extends LuceneTestCase {
- protected final Version version;
+ // spotless:off
Review Comment:
When you use google java formatter from intellij, for example, it will
ignore spotless markup and reformat the source anyway.
Any such remaining markup is a mistake. It will keep piling up - it's almost
never a good idea to have it.
I think those versions should be kept in plain text resources - then
updating them will be easier as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
