dweiss commented on code in PR #12979:
URL: https://github.com/apache/lucene/pull/12979#discussion_r1437904047
##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -409,8 +408,8 @@ public static final class IndexSortStatus {
}
/** Status from testing soft deletes */
- public static final class SoftDeletsStatus {
- SoftDeletsStatus() {}
+ public static final class SoftDeletesStatus {
Review Comment:
I think a single PR for one type of "mechanical" changes would be nice.
Those changes apply to one aspect of the source code but are not likely to
touch the API or the runtime behavior. For example, this PR could only touch
the UTF-8 refactoring - even though the patch affects a large number of files,
it's simpler to skim through them and perhaps cherry pick it to another branch.
When things are aggregated, it may be more difficult to untangle (or miss
something important among trivial replacements).
Thank you for doing these cleanups, they're definitely needed and there's
lots of cruft left over the years that could be improved (or modernized to new
APIs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
